Skip to content

fix(ui): disable (or rather don't enable) form validation after draft submit error #12918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ui): disable (or rather don't enable) form validation after draft submit error #12918

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17b50a4
fix(ui): don't enable validation after generic submit failure
philipp-tailor Jun 24, 2025
bb0f812
fix(ui): don't enable form validation after draft submit failure
philipp-tailor Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/ui/src/forms/Form/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,12 @@ export const Form: React.FC<FormProps> = (props) => {
setProcessing(false)
setSubmitted(true)

// When there was an error submitting a draft,
// set the form state to unsubmitted, to not trigger visible form validation on changes after the failed submit.
if (overridesFromArgs['_status'] === 'draft') {
setSubmitted(false)
}

contextRef.current = { ...contextRef.current } // triggers rerender of all components that subscribe to form
if (json.message) {
errorToast(json.message)
Expand Down
Loading