Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Make Service::class properties protected #82

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

r-kujawa
Copy link
Contributor

@r-kujawa r-kujawa commented Jun 29, 2024

What the diff?

  • Enhanced variable accessibility in Account class
    Changed '$serviceConfig' property's visibility from private to protected in multiple files.
  • Improved variable accessibility in Provider class
    Updated '$serviceConfig' property's accessibility from private to protected.
  • Modified Service class variable's access
    Adjusted the visibility of '$config', '$driver', '$provider', '$account', and '$gateway' from private to protected.
  • Increased method accessibility in ThrowsRuntimeException trait
    Updated 'throwRuntimeException' method's access from private to protected.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.13%. Comparing base (a20b983) to head (da6683d).

Files Patch % Lines
src/Traits/ThrowsRuntimeException.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #82   +/-   ##
=========================================
  Coverage     92.13%   92.13%           
  Complexity      190      190           
=========================================
  Files            22       22           
  Lines           661      661           
=========================================
  Hits            609      609           
  Misses           52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-kujawa r-kujawa merged commit 310c906 into master Jun 29, 2024
5 checks passed
@r-kujawa r-kujawa deleted the refactor-service_visibility branch June 29, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants