Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Refactor ServiceConfig::class. #81

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

r-kujawa
Copy link
Contributor

@r-kujawa r-kujawa commented Jun 28, 2024

What the diff?

This Pull Request primarily consists of updates and changes related to a software component we use to configure settings for various services, ServiceConfig. The significant changes are as follows:

  • Change in File Library Imports
    Across multiple files, we updated where ServiceConfig is imported from, changing it from the Fluent subdirectory to the primary Orchestration directory. This would ensure we're all using the latest version of ServiceConfig for our settings.

  • Use of Index-based Option Selection
    In the OrchestrateProvider.php file, the method of option selection was changed to use the index of the option rather than its value. This was done to provide a more standardized and error-free way of choosing settings.

  • Variables Assignment Update
    The OrchestrateService.php file introduced assignment expressions for improving the way we define and assign values to certain variables like $name and $id.

  • Standardization of Settings Retrieval
    Methods for settings retrieval(get method) were used more extensively in files like OrchestrateProvider.php and DatabaseDriver.php, providing a more standardized way to get the selected option's values.

  • Creation of New Source Files
    Two new files ServiceConfig.php and ServiceDriver.php were added to the src directory. These files are likely to include the updated configuration options and functionalities we're adopting, creating a better-organized codebase.

  • Modification in Test Files
    Multiple testing files were updated to import the new ServiceConfig path. This ensures our test suites are in alignment with the changes made in the codebase.

Overall, these changes bring a shift towards more secure and efficient ways of managing service configurations, contributing to an improved code quality and enhanced application reliability.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.13%. Comparing base (e2cf082) to head (a8565c8).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #81      +/-   ##
============================================
- Coverage     92.14%   92.13%   -0.02%     
- Complexity      189      190       +1     
============================================
  Files            22       22              
  Lines           662      661       -1     
============================================
- Hits            610      609       -1     
  Misses           52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-kujawa r-kujawa merged commit a20b983 into master Jun 28, 2024
5 checks passed
@r-kujawa r-kujawa deleted the refactor-service_config branch June 28, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants