Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Reconceptualize service DTO to config. #79

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

r-kujawa
Copy link
Contributor

@r-kujawa r-kujawa commented Jun 15, 2024

What does this PR do? 🤖

It didn't make sense that the \Payavel\Orchestration\Service::class had a$service property which solely held it's configurations. So this PR changes that by utilizing a new Fluent, ServiceConfig:class to hold those configurations.

Any background context you would like to provide? 🚧

Pointing at 3.x because it contains breaking changes, and the elimination of the Serviceable contract.

Does this relate to any issue? 🔗

Closes #73

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 96.94656% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.09%. Comparing base (81a3da2) to head (6d15510).

Files Patch % Lines
src/Drivers/ConfigDriver.php 97.14% 1 Missing ⚠️
src/Drivers/DatabaseDriver.php 95.65% 1 Missing ⚠️
src/Service.php 83.33% 1 Missing ⚠️
src/ServiceDriver.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
+ Coverage     92.94%   93.09%   +0.15%     
+ Complexity      193      190       -3     
============================================
  Files            23       22       -1     
  Lines           680      666      -14     
============================================
- Hits            632      620      -12     
+ Misses           48       46       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-kujawa r-kujawa merged commit ebeee27 into master Jun 24, 2024
5 checks passed
@r-kujawa r-kujawa deleted the enhancement-73-consolidate_service branch June 24, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants