Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Rename getStatus & getMessage methods. #41

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

r-kujawa
Copy link
Contributor

@r-kujawa r-kujawa commented Feb 7, 2024

What does this PR do? 🤖

Renames the ServiceResponse::class abstract methods getStatus & getMessage to getStatusMessage & getStatusDescription respectively.

Does this relate to any issue? 🔗

Closes #26

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c572f7) 92.25% compared to head (a89cffd) 92.25%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage     92.25%   92.25%           
  Complexity      181      181           
=========================================
  Files            21       21           
  Lines           633      633           
=========================================
  Hits            584      584           
  Misses           49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-kujawa r-kujawa merged commit 355d80c into master Feb 7, 2024
7 checks passed
@r-kujawa r-kujawa deleted the enhancement-26-rename_methods branch February 7, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename abstract methods getStatus & getMessage in the ServiceResponse::class.
2 participants