Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fix bug in tests. #61

Merged
merged 23 commits into from
Jun 12, 2024
Merged

[2.x] Fix bug in tests. #61

merged 23 commits into from
Jun 12, 2024

Conversation

r-kujawa
Copy link
Contributor

@r-kujawa r-kujawa commented Jun 5, 2024

What does this PR do? 🤖

Fixes issue where tests are assuming the database driver is being used.

How should this be tested? 🔬

phpunit

Does this relate to any issue? 🔗

Closes #57

@r-kujawa r-kujawa changed the title Bug 57 config factories Fix bug in tests. Jun 5, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 61.20%. Comparing base (469a8d7) to head (caba4b2).

Files Patch % Lines
src/Models/Payment.php 0.00% 3 Missing ⚠️
src/Models/PaymentInstrument.php 0.00% 3 Missing ⚠️
src/Models/Wallet.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #61      +/-   ##
============================================
- Coverage     61.69%   61.20%   -0.49%     
+ Complexity       87       79       -8     
============================================
  Files            18       17       -1     
  Lines           201      183      -18     
============================================
- Hits            124      112      -12     
+ Misses           77       71       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-kujawa r-kujawa changed the title Fix bug in tests. [2.x] Fix bug in tests. Jun 12, 2024
@r-kujawa r-kujawa merged commit 3f8f726 into master Jun 12, 2024
5 of 7 checks passed
@r-kujawa r-kujawa deleted the bug-57-config_factories branch June 12, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant