Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fix factory suppositions #60

Merged
merged 2 commits into from
May 20, 2024

Conversation

r-kujawa
Copy link
Contributor

What does this PR do? 🤖

Removes all model overriding capabilities from factories.

Any background context you would like to provide? 🚧

Factories are not intended to be extended to the end user if they wish to override their models. They should also choose to override their factories.

Does this relate to any issue? 🔗

Closes #59

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.69%. Comparing base (0972ae9) to head (928f9fe).

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
- Coverage     63.03%   61.69%   -1.35%     
+ Complexity       90       87       -3     
============================================
  Files            18       18              
  Lines           211      201      -10     
============================================
- Hits            133      124       -9     
+ Misses           78       77       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-kujawa r-kujawa merged commit 469a8d7 into master May 20, 2024
7 checks passed
@r-kujawa r-kujawa deleted the enhancement-59-overridding_factories branch May 20, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant