Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fix foreign key mismatch in base checkout migration. #54

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

r-kujawa
Copy link
Contributor

What does this PR do? 🤖

Fixes the foreign key mismatch with the base orchestration tables when using the database driver for a service.

How should this be tested? 🔬

Run php artisan checkout:install, choose the database driver & run php artisan migrate. No error should be thrown anymore.

Any background context you would like to provide? 🚧

payavel/orchestration#66 fixes the first point of #53, and this PR fixes the second point.

Does this relate to any issue? 🔗

Closes #53 and relates to payavel/orchestration#66.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.87%. Comparing base (a88ef92) to head (bd83202).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #54   +/-   ##
=========================================
  Coverage     31.87%   31.87%           
  Complexity       68       68           
=========================================
  Files            15       15           
  Lines           160      160           
=========================================
  Hits             51       51           
  Misses          109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-kujawa r-kujawa merged commit 5b9723c into master Apr 27, 2024
7 checks passed
@r-kujawa r-kujawa deleted the bug-53-database_driver_migrations branch April 27, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant