Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Load default migrations for this package if DX decides not to publish/modify them. #31

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

r-kujawa
Copy link
Contributor

@r-kujawa r-kujawa commented Apr 27, 2023

What does this PR do? 🤖

  • loadMigrationsFrom() automatically if DX does not feel the need to make any modifications.
  • Remove legacy workaround code that used to publish the migration.

Does this relate to any issue? 🔗

Closes #25

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +11.49 🎉

Comparison is base (b8e3dfb) 55.12% compared to head (a0c8d11) 66.61%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #31       +/-   ##
=============================================
+ Coverage     55.12%   66.61%   +11.49%     
+ Complexity      222      221        -1     
=============================================
  Files            42       42               
  Lines           702      701        -1     
=============================================
+ Hits            387      467       +80     
+ Misses          315      234       -81     
Impacted Files Coverage Δ
src/Console/Commands/Install.php 100.00% <ø> (+1.66%) ⬆️
src/PaymentServiceProvider.php 96.42% <80.00%> (+3.83%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@r-kujawa r-kujawa merged commit 4f876c8 into master Apr 27, 2023
@r-kujawa r-kujawa deleted the enhancement-25-loadMigrationsFrom branch April 27, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant