Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --major-version-zero #58

Merged
merged 16 commits into from
Nov 4, 2023

Conversation

sandzhaj
Copy link
Contributor

@sandzhaj sandzhaj commented Oct 8, 2023

Change default behavior for major version bumps.
Now, major versions are always bumped for breaking changes. --major-version-zero flag restores previous behaviour

Resolves: #57
Issue #57: #57

src/git_changelog/cli.py Outdated Show resolved Hide resolved
src/git_changelog/cli.py Outdated Show resolved Hide resolved
@pawamoy
Copy link
Owner

pawamoy commented Nov 4, 2023

For some reason this PR included changes from #60, so I removed them.

Eventually I decided to keep the current behavior of maintaining zerover by default. CI users can set zerover = true in their config file, then change it to false and commit a breaking change when they are ready to bump to v1. Then they can keep the setting, or remove it, since it has no effect after v1 is released.

CLI users just have to force bump to 1.0.0 or use --bump auto -Z when they're ready.

Let me know what you think 🙂 !

@pawamoy pawamoy self-assigned this Nov 4, 2023
@sandzhaj
Copy link
Contributor Author

sandzhaj commented Nov 4, 2023

That's great, thanks

@pawamoy pawamoy merged commit 7d0c259 into pawamoy:main Nov 4, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update major for breaking changes in 0.x versions by default
2 participants