Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ignore paths globifying #539

Closed
wants to merge 1 commit into from
Closed

Improve ignore paths globifying #539

wants to merge 1 commit into from

Commits on Oct 8, 2016

  1. Improve ignore paths globifying 

    Ensures that if only a directory's basename is provided (without the preceeding path, just `dirname`), it prefixes `**/`

Currently when only a directory name is provided, it adds a postfix `/**` which is great for matching the entire tree ***if*** the tree is a *child* of the dir.  So `path` (converted to `path/**`) can filter paths like `path/to/file.js`, **but** if `path` is actually only a directory's basename it fails to match `/some/path/to/file.js`. This can be solved by prefixing `**/path`

Really helpful when only "node_modules" is provided as ignore path (like in `.gitignore` file) and it's actually some level deeper than current dir.

Also adjust the postfix to add just `**` instead of `/**` based on if last char is already a `/`
    @laggingreflex
    laggingreflex committed Oct 8, 2016
    Configuration menu
    Copy the full SHA
    e4aff97 View commit details
    Browse the repository at this point in the history