This repository has been archived by the owner on Jun 12, 2020. It is now read-only.
Add restic_mode variable #42
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,6 +72,11 @@ | |
| owner: 'root' | ||
| group: '{{ restic_group }}' | ||
|
|
||
| - name: Read status of restic binary | ||
| stat: | ||
| path: '{{ restic_install_path }}/restic' | ||
| register: restic_binary | ||
|
|
||
| - name: Install libcap on Debian systems | ||
| apt: | ||
| name: "libcap2-bin" | ||
|
|
@@ -80,6 +85,7 @@ | |
| when: | ||
| - ansible_os_family | lower == "debian" | ||
| - restic_user != 'root' | ||
| - restic_group != 'root' | ||
|
|
||
| - name: Set proper capabilities for restic binary | ||
| capabilities: | ||
|
|
@@ -88,4 +94,6 @@ | |
| state: present | ||
| when: | ||
| - restic_user != 'root' | ||
| - restic_group != 'root' | ||
|
|
||
| - not ansible_check_mode | ||
|
There was a problem hiding this comment. @TheLastProject This does not come from my PR, but still: what is this line for? The tasks are always run when not ansible_check_mode, no? Did I make a mistake in my thinking? There was a problem hiding this comment. .. and skipped when in Check/Test-Mode. There was a problem hiding this comment. I think it's just to not fail if the capabilities are not set |
||
| - not restic_binary.stat.xoth | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheLastProject I think this line is wrong too, right?
libcap2-binshould be installed if restic_user OR restic_group are not 'root', like this:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is @paulfantom's code, but it seems to me that that indeed should be changed.