-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add loo_epred #1643
add loo_epred #1643
Conversation
Can you remind me which decisions need to be made? |
What should be the order of dimensions for multioutput target? See how I coded and documented now, but there is also an alternative and I was not sure which you would prefer. Now I don't remember why I wrote "couple" |
Thanks! I would prefer observations to be rows and response variables to be columns. I understand that you currently implemented in the other way around? |
The current doc says for
So here one column per observation. For
So here one row per observation For
So one column per observation, and possible third dimension for multioutput. So it seems column vs row is 2-1 But, then
Not in this PR, but mentioning in case if it would affect the logic, that it might be useful to have also such LOO predictive functions that return S importance-resampled draws instead of using |
Thanks! I will think about it today and ideally even edit and merge this PR today. :-) |
I have now made a couple of edits to make the output format of all these loo_* functions consistent with out post-processing functions that also return per-observation information. That is, observation are now always represented as rows. |
Thank you for this PR! |
I kept thinking that there was another thing to make decision and now I remembered it! Note that there is a comment on line
as corresponding |
I know. I have temporarily added the loo_epred generic in brms. Once the new rstantools is on CRAN, I will remove it from brms. |
Fixes #1641, but requires couple decisions before merged