Skip to content

feat(Drawer): Added support for glass#12305

Draft
tlabaj wants to merge 3 commits intopatternfly:mainfrom
tlabaj:drawer_glass
Draft

feat(Drawer): Added support for glass#12305
tlabaj wants to merge 3 commits intopatternfly:mainfrom
tlabaj:drawer_glass

Conversation

@tlabaj
Copy link
Copy Markdown
Contributor

@tlabaj tlabaj commented Mar 31, 2026

What: Closes #12273

  • Changes to drawer:

    • DrawerColorVariant.noBackground marked @deprecated in enum
  • Changes to DrawerPanelContent:

    • added isGlass (@beta, default false) — applies pf-m-glass
    • added isPlain (@beta, default false) — applies pf-m-plain
    • added isNoPlainOnGlass (@beta, default false) — applies pf-m-no-plain
    • DrawerColorVariant.noBackground marked @deprecated; migrate to isPlain for plain styling (still applies pf-m-no-background so existing snapshots and consumers stay stable).
    • Added unit tests for isGlass, isPlain, isNoPlainOnGlass, and clarified test name for deprecated no-background
  • Changes for DrawerSection:

    • added isPlain (@beta, default false) — applies pf-m-plain

    • DrawerColorVariant.noBackground marked @deprecated; migrate to isPlain for plain styling (still applies pf-m-no-background so existing snapshots and consumers stay stable).

    • Added new test for isPlain

    • Updated PrimaryDetailContentPadding demo: DrawerPanelContent uses isPlain; removed invalid DrawerContent colorVariant="no-background" (not supported on DrawerContent)

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7e5b66c1-7cf3-4aa1-be0b-1e2f9428f774

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build
Copy link
Copy Markdown
Collaborator

patternfly-build commented Mar 31, 2026

@tlabaj
Copy link
Copy Markdown
Contributor Author

tlabaj commented Apr 13, 2026

This PR is waiting for patternfly/patternfly#8267 to be fixed.

@mcoker
Copy link
Copy Markdown
Contributor

mcoker commented Apr 13, 2026

@tlabaj just closed patternfly/patternfly#8267, it was done in patternfly/patternfly#8266 which should be in core 6.5.0-prerelease.67

@tlabaj
Copy link
Copy Markdown
Contributor Author

tlabaj commented Apr 13, 2026

@mcoker The modifiers do not seem to be working as expected. isPlain on the DrawerPanelContent does not seem to remove the background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drawer - Glass style follow up

3 participants