chore(Demos): updated logo in dashboardheader#11552
Merged
mfrances17 merged 1 commit intopatternfly:mainfrom Feb 24, 2025
Merged
chore(Demos): updated logo in dashboardheader#11552mfrances17 merged 1 commit intopatternfly:mainfrom
mfrances17 merged 1 commit intopatternfly:mainfrom
Conversation
thatblindgeye
requested review from
a team,
lboehling,
mfrances17 and
tlabaj
and removed request for
a team
Collaborator
|
Preview: https://patternfly-react-pr-11552.surge.sh A11y report: https://patternfly-react-pr-11552-a11y.surge.sh |
kmcfaul
approved these changes
Feb 20, 2025
mfrances17
approved these changes
Feb 20, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11163
Instead of imprting the logo file, using a hardcoded svg (taken from Org codebase) in both DashboardHeader files so that the text color in the svgs updates automatically based on the theme.
Additional issues: