chore(Password demos): moved to Patterns#11539
Merged
mfrances17 merged 2 commits intopatternfly:mainfrom Feb 20, 2025
Merged
Conversation
thatblindgeye
requested review from
a team,
kmcfaul and
mfrances17
and removed request for
a team
Collaborator
|
Preview: https://patternfly-react-pr-11539.surge.sh A11y report: https://patternfly-react-pr-11539-a11y.surge.sh |
mfrances17
suggested changes
Feb 17, 2025
Contributor
mfrances17
left a comment
mfrances17
left a comment
There was a problem hiding this comment.
code changes are good 👍
i realize this is tangential to the proposed changes, but in the example, i would expect type="text" on ln 105 to be type="password" to be more realistic - what do you think?
Contributor
Author
Good catch, since we're in here I went ahead and made that update |
mfrances17
approved these changes
Feb 18, 2025
thatblindgeye
force-pushed
the
passwordDemos
branch
from
836c934 to
fb61589
Compare
thatblindgeye
force-pushed
the
passwordDemos
branch
from
fb61589 to
f0aa85e
Compare
kmcfaul
approved these changes
Feb 20, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #10105
Additional issues: