fix(CodeEditor): do not include extra div if headerMainContent is unset#11534
Merged
thatblindgeye merged 1 commit intopatternfly:mainfrom Feb 17, 2025
Merged
fix(CodeEditor): do not include extra div if headerMainContent is unset#11534thatblindgeye merged 1 commit intopatternfly:mainfrom
headerMainContent is unset#11534thatblindgeye merged 1 commit intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11534.surge.sh A11y report: https://patternfly-react-pr-11534-a11y.surge.sh |
Contributor
|
Looks like this just needs a snapshot update for the failing test (since the extra div is not included anymore). You should be able to update it with |
logonoff
force-pushed
the
codeeditor2
branch
from
bfacf43 to
4f2423e
Compare
nicolethoen
approved these changes
Feb 14, 2025
thatblindgeye
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11533