fix(CodeEditor): ensure that handleResize works when viewport shrinks#11532
Merged
thatblindgeye merged 1 commit intopatternfly:mainfrom Feb 17, 2025
Merged
fix(CodeEditor): ensure that handleResize works when viewport shrinks#11532thatblindgeye merged 1 commit intopatternfly:mainfrom
thatblindgeye merged 1 commit intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11532.surge.sh A11y report: https://patternfly-react-pr-11532-a11y.surge.sh |
kmcfaul
approved these changes
Feb 14, 2025
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
I wasn't able to reproduce this bug exactly with our docs examples (maybe because its not contained in other components), but the change looks sound and doesn't introduce any new issues that I can find.
nicolethoen
approved these changes
Feb 14, 2025
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
I tested this change in our chatbot extension and don't see any negative side effects to the code editors used in the extension. so LGTM ✅
thatblindgeye
approved these changes
Feb 17, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #11531