feat(JumpLinks): Add replaceNavHistory option#11473
Merged
tlabaj merged 1 commit intopatternfly:mainfrom Jan 27, 2025
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11473.surge.sh A11y report: https://patternfly-react-pr-11473-a11y.surge.sh |
mfrances17
requested review from
a team,
mfrances17 and
tlabaj
and removed request for
a team
| /** Class for nav */ | ||
| className?: string; | ||
| /** Whether the navigation history should be replaced rather than pushed */ | ||
| replaceNavHistory?: boolean; |
Contributor
There was a problem hiding this comment.
Suggested change
| replaceNavHistory?: boolean; | |
| shouldReplaceNavHistory?: boolean; |
| toggleAriaLabel?: string; | ||
| /** Class for nav */ | ||
| className?: string; | ||
| /** Whether the navigation history should be replaced rather than pushed */ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** Whether the navigation history should be replaced rather than pushed */ | |
| /** Whether the current entry in the navigation history should be replaced when a JumpLinksItem is clicked. By default a new entry will be pushed to the navigation history. */ |
Maybe something like this for the description? Just to make it clear that only the current history item would be replaced rather than the entire history being replaced.
mfrances17
approved these changes
Jan 24, 2025
Contributor
mfrances17
left a comment
mfrances17
left a comment
There was a problem hiding this comment.
LGTM w/ Eric's suggestions 👍
jeff-phillips-18
force-pushed
the
jumplinks-nav-fix
branch
from
3d4e9ce to
08f93d6
Compare
Member
Author
|
@thatblindgeye Thanks, updated. |
thatblindgeye
approved these changes
Jan 27, 2025
tlabaj
approved these changes
Jan 27, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
mattnolting
pushed a commit
to mattnolting/patternfly-react
that referenced
this pull request
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Closes #11471