-
Notifications
You must be signed in to change notification settings - Fork 20
Clarify frontmatter requirements in contributing-skills.md #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wise-king-sullyman
wants to merge
1
commit into
patternfly:main
Choose a base branch
from
wise-king-sullyman:clarify-frontmatter-requirements-in-skills
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to push back on "needs" here.
Here's a working example with no frontmatter: unit-test-generator/SKILL.md — it registers fine as /pf-react:unit-test-generator:

Skills are discovered by directory path, not frontmatter. A description is important — but it can just be the first line of the SKILL.md, it doesn't need to be in YAML frontmatter. And name is redundant since the directory name is the skill name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, when I first tried to use my skill without adding the frontmatter claude couldn't find it or this unit-test-generator skill 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How were you trying to find it exactly? Maybe you could demonstrate this. I don't mind making it a requirement - but it seems its not at least in terms of Claude Code discovery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into this more - the skills npm package (a 3rd party tool) does not discover skills unless they have a "name" - so that's an incentive here at least. Also, the Claude code official docs do cite it - linked to slash command usage - https://code.claude.com/docs/en/skills. So I think this is enough to just make it a requirement for us.