feat: add patternfly component structure skill#31
Open
nicolethoen wants to merge 3 commits intopatternfly:mainfrom
Open
feat: add patternfly component structure skill#31nicolethoen wants to merge 3 commits intopatternfly:mainfrom
nicolethoen wants to merge 3 commits intopatternfly:mainfrom
Conversation
jpuzz0
reviewed
Mar 20, 2026
| @@ -0,0 +1,331 @@ | |||
| --- | |||
| name: PatternFly Component Structure | |||
Collaborator
There was a problem hiding this comment.
The directory name patternfly-component-structure is what determines the skill name — this name field is redundant and not kebab-case. Safe to just remove it.
| @@ -0,0 +1,331 @@ | |||
| --- | |||
Collaborator
There was a problem hiding this comment.
At 331 lines this is well over the 200-line guideline. You already have 4 reference files — could more of the component hierarchy details be moved there to keep the core instructions shorter?
| @@ -0,0 +1,142 @@ | |||
| --- | |||
Collaborator
There was a problem hiding this comment.
This agent has a "How to Run" workflow and produces a report — that reads more like a skill (task that produces a result) than an agent (domain knowledge the AI always follows). Meanwhile the SKILL.md reads more like reference knowledge. Are these two swapped?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #32
This skill provides AI agents and developers with the correct parent-child component hierarchies for PatternFly React components. Without it, users commonly skip intermediate wrapper components (like ToolbarContent, CardBody, PageSection, DrawerContentBody, etc.) that provide essential CSS classes for spacing, padding, and alignment. This leads to broken layouts that get "fixed" with custom CSS overrides instead of correcting the component tree. The skill covers 13 component families including Page, Masthead, Toolbar, Card, Modal, Drawer, Nav, Table, DataList, Tabs, EmptyState, DescriptionList, and Sidebar, with wrong/right code examples for the most common mistakes.