Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial migration of table-controls code from konveyor/tackle2-ui #1

Merged
merged 65 commits into from
Nov 2, 2023

Conversation

mturley
Copy link
Collaborator

@mturley mturley commented Oct 25, 2023

  • Migrates code from https://github.com/konveyor/tackle2-ui/tree/ded98a9/client/src/app/hooks/table-controls and other common paths in tackle2-ui
  • Creates tackle2-ui-legacy directory for Konveyor-specific implementations that still need to be rewritten / refactored
  • Installs @migtools/lib-ui for now, we will remove that dependency by copying over additional legacy code in a separate PR
  • Fixes imported code to work with dependency versions from pf-extension-seed
  • Converts documentation from OLD_DOCS.md to a new (mostly rewritten) pf-docs site with embedded examples
    • Some advanced examples are stubs that will be replaced in a separate PR
    • Also creates CONTRIBUTING.md for some extra maintainer-facing details that don't belong in consumer docs
    • Note that these efforts are not complete (some stuff is still in OLD_DOCS.md) but I don't want to block merging this so I will follow up on them in a separate PR
  • Changes here compared to the code as it was in tackle2-ui:
    • Ran Prettier (the prettierrc config from pf-extension-seed is different from the one in tackle2-ui)
    • Fixed import paths
    • Removed dependency on react-i18n (leaving TODO comments in places where we should add support for custom text / future i18n)
    • Removed dependency on react-router-dom (was used by useUrlParams which now works directly with the browser history API instead)
    • Fixed type errors, lint errors and a11y report errors
    • Renamed hooks, helpers, types etc to fit the new table-batteries naming conventions
    • Misc general cleanup

The docs site can be previewed at https://react-table-batteries-staging.surge.sh/extensions/table-batteries

@mturley mturley force-pushed the initial-tackle-import branch 3 times, most recently from dfc0887 to 9f5a1e6 Compare November 1, 2023 14:21
@mturley mturley changed the title [WIP] Initial migration of table-controls code from konveyor/tackle2-ui Initial migration of table-controls code from konveyor/tackle2-ui Nov 1, 2023
@mturley mturley marked this pull request as ready for review November 1, 2023 17:06
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
…f we can change the docs framework webpack config?)

Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
Signed-off-by: Mike Turley <[email protected]>
@mturley mturley force-pushed the initial-tackle-import branch from b7b62ed to e0ffc91 Compare November 1, 2023 22:14
@mturley mturley merged commit 66de5f8 into main Nov 2, 2023
4 checks passed
@mturley mturley deleted the initial-tackle-import branch November 2, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants