Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate submit call in FormikWizard submit button #24

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Remove duplicate submit call in FormikWizard submit button #24

merged 1 commit into from
Dec 5, 2022

Conversation

rottencandy
Copy link
Contributor

Fixes #23

The submit handler is already called by <Form> when submit is pressed, so the extra onclick run is not needed.
This does not affect Chrome.

@rottencandy
Copy link
Contributor Author

cc @rohitkrai03

rohitkrai03
rohitkrai03 approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@rohitkrai03 rohitkrai03 merged commit b06ea89 into patternfly-labs:main Dec 5, 2022
@rottencandy rottencandy deleted the fix/firefox-submit branch December 6, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Submit handlers are run twice on Firefox
2 participants
@rottencandy @rohitkrai03