Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MASTER:: NOTICKET :: Allow control of the faker seed results #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaunceyt
Copy link

No description provided.

@AndyIRC
Copy link
Contributor

AndyIRC commented Oct 2, 2018

Thank you very much for this. As hard as this might be to believe, my colleague and I just sat down to branch PL Faker to include this exact feature. We are already running from a branch (see Issue 2), but hopefully the owner of this repo can get around to merge our changes back to master.

@AndyIRC
Copy link
Contributor

AndyIRC commented Feb 4, 2019

@chaunceyt would you mind rerolling this patch, please? it doesnt apply when using https://github.com/cweagans/composer-patches, as I think someone added some code on the master branch right after you and it conflicts (even thought GitHub says that it does not).

nerfchicken added a commit to nerfchicken/plugin-php-faker that referenced this pull request Feb 5, 2019
Since these 2 pull requests haven't been accepted, I forked the project:
pattern-lab#7
pattern-lab#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants