This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
alignment with edition-node-gulp dependencies
- Loading branch information
1 parent
64abb92
commit e075c39
Showing
135 changed files
with
2,408 additions
and
10,435 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Contributing to Patternlab Node | ||
| If you'd like to contribute to Pattern Lab Node, please do so! There is always a lot of ground to cover and something for your wheelhouse. | ||
|
|
||
| No pull request is too small. Check out any [up for grabs issues](https://github.com/pattern-lab/patternlab-node/labels/up%20for%20grabs) as a good way to get your feet wet, or add some more unit tests. | ||
|
|
||
| ## Guidelines | ||
| 1. Please keep your pull requests concise and limited to **ONE** substantive change at a time. This makes reviewing and testing so much easier. | ||
| 2. _ALWAYS_ submit pull requests against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, port over your contribution manually if time allows, and/or third, close your pull request. If you have a major feature to stabilize over time, talk to @bmuenzenmeyer about making a dedicated `feature-branch` | ||
| 3. If you can, add some unit tests using the existing patterns in the `./test` directory | ||
|
|
||
| ##Coding style | ||
| Two files combine within the project to define and maintain our coding style. | ||
|
|
||
| * The `.editorconfig` controls spaces / tabs within supported editors. Check out their [site](http://editorconfig.org/). | ||
| * The `.eslintrc` defines our javascript standards. Some editors will evaluate this real-time - otherwise it's run using `grunt|gulp build` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <!-- before posting an issue, try chatting on https://gitter.im/pattern-lab/node --> | ||
| <!-- before posting an issue, verify you are running at least Node 4 or 5 AND Gulp 4 --> | ||
|
|
||
| I am using Edition Node Gulp `vX.X.X` on `Windows | Mac | Linux`, with Node `vX.X.X`, Gulp-CLI `vX.X.X` and Gulp `vX.X.X`. | ||
|
|
||
| ##### Expected Behavior | ||
|
|
||
|
|
||
| ##### Actual Behavior | ||
|
|
||
|
|
||
| ##### Steps to Reproduce |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <!-- **Please read the contribution guidelines first, and target the `dev` branch!** --> | ||
|
|
||
| Addresses # | ||
|
|
||
| Summary of changes: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,9 @@ | ||
| var comments = { | ||
| "comments" : [ | ||
| { | ||
| "el": "header[role=banner]", | ||
| "title" : "Masthead", | ||
| "comment": "The main header of the site doesn't take up too much screen real estate in order to keep the focus on the core content. It's using a linear CSS gradient instead of a background image to give greater design flexibility and reduce HTTP requests." | ||
| }, | ||
| { | ||
| "el": ".logo", | ||
| "title" : "Logo", | ||
| "comment": "The logo image is an SVG file, which ensures that the logo displays crisply even on high resolution displays. A PNG fallback is provided for browsers that don't support SVG images.</p><p>Further reading: <a href=\"http://bradfrostweb.com/blog/mobile/hi-res-optimization/\">Optimizing Web Experiences for High Resolution Screens</a></p>" | ||
| }, | ||
| { | ||
| "el": "#nav", | ||
| "title" : "Navigation", | ||
| "comment": "<p>Navigation for adaptive web experiences can be tricky. Top navigations are typical on desktop sites, but mobile screen sizes don't give us the luxury of space. We're dealing with this situation by creating a simple menu anchor that toggles the main navigation on small screens. This is just one method. <a href=\"http://bagcheck.com/\">Bagcheck</a> and <a href=\"http://contentsmagazine.com/\">Contents Magazine</a> add an anchor in the header that jumps users to the navigation which is placed in the footer. This solution works well because it doesn't require any Javascript in order to work. Other methods exist too. For example, <a href=\"http://m.espn.com\">ESPN's mobile navigation</a> overlays the main content of the page.</p><p>The nav is only hidden when a certain level of javascript is supported in order to ensure that users with little/poor javascript support can still access the navigation. Once the screen size is large enough to accommodate the nav, we show the main navigation links and hide the menu anchor.<p><p>See also: <a href=\"http://bradfrostweb.com/blog/web/responsive-nav-patterns/\">Responsive Navigation Patterns</a></p>" | ||
| }, | ||
| { | ||
| "el": ".search-form", | ||
| "title" : "Search", | ||
| "comment": "<p>Search is an incredibly important priority, especially for mobile. It is a great idea to give users the ability to jump directly to what they are looking for without forcing them to wade through your site's navigation. Check out the <a href=\"http://burton.com\">Burton</a> and <a href=\"http://yelp.com\">Yelp</a> mobile sites for great examples of experiences that prioritize search.</p><p>We're also using the <a href=\"http://dev.w3.org/html5/markup/input.search.html\">HTML5 search input type</a>, which is great for mobile devices that can <a href=\"http://diveintohtml5.info/forms.html\">bring up the appropriate virtual keyboard</a> for many smartphones. And like the main header navigation, we're hiding the search form on small screens to save space. Clicking the search anchor toggles the form. </p>" | ||
| }, | ||
| { | ||
| "el": ".article-header h1", | ||
| "title" : "Article Header", | ||
| "comment": "<p>The article header should be no more than 140 characters. </p>" | ||
| }, | ||
| { | ||
| "el": ".block-hero", | ||
| "title" : "Hero", | ||
| "comment": "<p>The hero area highlights one major story using a large image and a captivating headline.</p>" | ||
| } | ||
| ] | ||
| "comments" : [ | ||
| { | ||
| "el": "#colors", | ||
| "title" : "Special Markup and Styling", | ||
| "comment": "This code uses pattern-scaffolding.css in the `source/css/` directory." | ||
| } | ||
| ] | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,4 +90,4 @@ | |
| { }, | ||
| { } | ||
| ] | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
|
|
||
| <!--DO NOT REMOVE--> | ||
| {{{ patternLabFoot }}} | ||
|
|
||
| </body> | ||
| </html> | ||
| <!--DO NOT REMOVE--> | ||
| {{{ patternLabFoot }}} | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ## Humble Beginnings | ||
|
|
||
| Don't you love a good grayscale? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,26 @@ | ||
| <ul class="sg-colors"> | ||
| <ul class="sg-colors" id="colors"> | ||
| <li> | ||
| <span class="sg-swatch" style="background: #ff0000;"></span> | ||
| <span class="sg-label">#ff0000</span> | ||
| </li> | ||
| <li> | ||
| <span class="sg-swatch" style="background: #00ff00;"></span> | ||
| <span class="sg-label">#00ff00</span> | ||
| </li> | ||
| <li> | ||
| <span class="sg-swatch" style="background: #0000ff;"></span> | ||
| <span class="sg-label">#0000ff</span> | ||
| </li> | ||
| <li> | ||
| <span class="sg-swatch" style="background: #ffff00;"></span> | ||
| <span class="sg-label">#ffff00</span> | ||
| <span class="sg-swatch" style="background: #ffffff;"></span> | ||
| <span class="sg-label">#ffffff</span> | ||
| </li> | ||
| <li> | ||
| <span class="sg-swatch" style="background: #00ffff;"></span> | ||
| <span class="sg-label">#00ffff</span> | ||
| <span class="sg-swatch" style="background: #cccccc;"></span> | ||
| <span class="sg-label">#cccccc</span> | ||
| </li> | ||
| <li> | ||
| <span class="sg-swatch" style="background: #ff00ff;"></span> | ||
| <span class="sg-label">#ff00ff</span> | ||
| <span class="sg-swatch" style="background: #999999;"></span> | ||
| <span class="sg-label">#999999</span> | ||
| </li> | ||
| <li> | ||
| <span class="sg-swatch" style="background: #ffffff;"></span> | ||
| <span class="sg-label">#ffffff</span> | ||
| <span class="sg-swatch" style="background: #666666;"></span> | ||
| <span class="sg-label">#666666</span> | ||
| </li> | ||
| <li> | ||
| <span class="sg-swatch" style="background: #808080;"></span> | ||
| <span class="sg-label">#808080</span> | ||
| <span class="sg-swatch" style="background: #333333;"></span> | ||
| <span class="sg-label">#333333</span> | ||
| </li> | ||
| <li> | ||
| <span class="sg-swatch" style="background: #000000;"></span> | ||
| <span class="sg-label">#000000</span> | ||
| </li> | ||
| </ul> | ||
| </ul> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| <p>Primary font: "HelveticaNeue", "Helvetica", "Arial", sans-serif;</p> | ||
| <p><em>Primary font italic: "HelveticaNeue", "Helvetica", "Arial", sans-serif;</em></p> | ||
| <p><strong>Primary font bold: "HelveticaNeue", "Helvetica", "Arial", sans-serif;</strong></p> | ||
| <p class="font-secondary">Secondary font: Georgia, Times, "Times New Roman", serif;</p> | ||
| <p class="font-secondary"><em>Secondary font italic: Georgia, Times, "Times New Roman", serif;</em></p> | ||
| <p class="font-secondary"><strong>Secondary font bold: Georgia, Times, "Times New Roman", serif;</strong></p> | ||
| <div>Primary font: "HelveticaNeue", "Helvetica", "Arial", sans-serif;</div> | ||
| <div><em>Primary font italic: "HelveticaNeue", "Helvetica", "Arial", sans-serif;</em></div> | ||
| <div><strong>Primary font bold: "HelveticaNeue", "Helvetica", "Arial", sans-serif;</strong></div> | ||
| <div class="font-secondary">Secondary font: Georgia, Times, "Times New Roman", serif;</div> | ||
| <div class="font-secondary"><em>Secondary font italic: Georgia, Times, "Times New Roman", serif;</em></div> | ||
| <div class="font-secondary"><strong>Secondary font bold; Georgia, Times, "Times New Roman", serif;</strong></div> |
Oops, something went wrong.