Merge pull request CMSgov#33 from CMSgov/conditional-refactor

minor refactor to remove the 'not' conditional language
patsier-cms · Apr 22, 2024 · eca314c · eca314c
2 parents 6f49e55 + 23d1183
commit eca314c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 11 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "hpt-validator",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "author": "CMS Open Source <[email protected]>",
   "license": "CC0-1.0",
   "description": "Validation library for CMS Hospital Price Transparency machine-readable files",

diff --git a/src/versions/2.0/json.ts b/src/versions/2.0/json.ts
@@ -87,16 +87,15 @@ const STANDARD_CHARGE_DEFINITIONS = {
       properties: {
         payers_information: {
           type: "array",
-          items: {
+          contains: {
             type: "object",
-            not: {
-              required: ["standard_charge_dollar"],
-            },
+            required: ["standard_charge_dollar"],
           },
         },
       },
+      required: ["payers_information"],
     },
-    else: {
+    then: {
       required: ["minimum", "maximum"],
     },
   },

diff --git a/test/2.0/json.spec.ts b/test/2.0/json.spec.ts
@@ -171,7 +171,7 @@ test("validateJsonConditionals", async (t) => {
     {
       path: "/standard_charge_information/1/standard_charges/0",
       field: "0",
-      message: 'must match "else" schema',
+      message: 'must match "then" schema',
     },
     {
       path: "/standard_charge_information/2/standard_charges/0",
@@ -181,7 +181,7 @@ test("validateJsonConditionals", async (t) => {
     {
       path: "/standard_charge_information/2/standard_charges/0",
       field: "0",
-      message: 'must match "else" schema',
+      message: 'must match "then" schema',
     },
     {
       path: "/standard_charge_information/3/standard_charges/0",
@@ -191,7 +191,7 @@ test("validateJsonConditionals", async (t) => {
     {
       path: "/standard_charge_information/3/standard_charges/0",
       field: "0",
-      message: 'must match "else" schema',
+      message: 'must match "then" schema',
     },
   ])
 })