Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update GitHub Actions to fix deprecation warnings #66

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MWin123
Copy link
Contributor

@MWin123 MWin123 commented Jun 13, 2024

PR description

This fixes the deprecation warnings as described in #65.

I just increased the version of each GitHub Action to the latest stable one. I assumed that they didn't include any breaking changes without making it obvious in the README but I might be wrong.

It passed with this CI runner but apparently the commit didn't retain the Git tag in the PR? I guess that's working as intended because you don't want to create releases from PRs. I already increased the minor version in the build.gradle to 2.10.0. While CI passed, it didn't run all updated GitHub Actions because some require a release from a tagged commit.

All deprecation warnings disappared as well: https://github.com/patschuh/KafkaEsque/actions/runs/9508209353

windows-2022
Failed to save: "C:\Program failed with error: The process 'C:\Program Files\Git\usr\bin\tar.exe' failed with exit code 2

One unrelated one is left, it seems like this is a minor bug where tries to use tar (instead of zip?) on Windows.

I'd probably just try it out by merging the PR, worst case is you have to revert that one commit. Don't forget to add the Git tag for v2.10.0 to create a release so it runs all updated GitHub Actionsl

CI on forks (help required, low prio)

I currently don't have the correct setup for all actions, e.g., the "Create release" step fails. I think it required an env variable and/or env secret but I'm not sure what exactly you had to do.

See https://github.com/MWin123/KafkaEsque/actions/runs/9507785065/job/26207904249 where it fails in that step.

@patschuh do you still remember what was required? If yes, could you please PM me a screenshot of the correct env vars and required permissions from the repo's setting?

@MWin123 MWin123 changed the title Update GitHub Actions to fix deprecation warnings [CI] Update GitHub Actions to fix deprecation warnings Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant