Don’t show comments from .gitignore #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a `.gitignore` file has comment lines, `browser-refresh` will announce them as patterns, like so: ```sh $ browser-refresh index.js [browser-refresh] Watching: /Users/me/git/project [browser-refresh] Ignore rule: #### MacOS #### [browser-refresh] Ignore rule: .DS_Store [browser-refresh] Ignore rule: .AppleDouble [browser-refresh] Ignore rule: .LSOverride [browser-refresh] Ignore rule: # Icon must end with two \r [browser-refresh] Ignore rule: Icon [browser-refresh] Ignore rule: # Thumbnails [browser-refresh] Ignore rule: ._* [browser-refresh] Ignore rule: #### Node.JS #### ``` I’m unsure this is the place to filter them out, though — _technically_ a filename can start with the gitconfig comment characters (`#` and `;`). I couldn’t find the code that parses out patterns from `.gitignore`, but if you show me where I’ll filter there instead!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
.gitignorefile has comment lines,browser-refreshwill announce them as patterns, like so:I’m unsure this is the place to filter them out, though — technically a filename can start with the gitconfig comment characters (
#and;). I couldn’t find the code that parses out patterns from.gitignore, but if you show me where I’ll filter there instead!