Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding qudt QuantityKind mappings. #563

Merged
merged 4 commits into from
Aug 10, 2024
Merged

Adding qudt QuantityKind mappings. #563

merged 4 commits into from
Aug 10, 2024

Conversation

cmungall
Copy link
Contributor

@cmungall cmungall commented Aug 9, 2024 •
edited
Loading

See #101

I modeled as exactMatch, even though the ontological modeling may be different (qudt QuantityKinds follow a more skos like model)

@cmungall cmungall requested a review from matentzn August 9, 2024 18:54
matentzn
matentzn approved these changes Aug 10, 2024
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cmungall

I have registered the sssom file in the config as well, this way it becomes more transparent which mappings are maintained, and which ones are imported by the project!

@matentzn matentzn merged commit 38ceca9 into master Aug 10, 2024
1 check passed
@matentzn matentzn deleted the adding-qudt-kind-mappings branch August 10, 2024 06:50
anitacaron added a commit that referenced this pull request Aug 16, 2024
@anitacaron
add missing config in odk to use sssom mapping set added in PR #563
a435ec9
anitacaron added a commit that referenced this pull request Aug 19, 2024
@anitacaron
add missing config in odk to use sssom mapping set added in PR #563 (#…
a6fcdc9 
…570)

Co-authored-by: Anita Caron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmungall @matentzn