Skip to content

Improved diff installation#178

Open
Szczyrk wants to merge 9 commits intodev/v3.17.x.xfrom
experimental/improved-download-unpacking-installation
Open

Improved diff installation#178
Szczyrk wants to merge 9 commits intodev/v3.17.x.xfrom
experimental/improved-download-unpacking-installation

Conversation

@Szczyrk
Copy link
Collaborator

@Szczyrk Szczyrk commented Sep 23, 2021

No description provided.

Szczyrk and others added 8 commits September 20, 2021 16:38
Co-authored-by: Jakub Szczyrk <Jakub Szczyrk>
Co-authored-by: Jakub Szczyrk <Jakub Szczyrk>
Co-authored-by: Jakub Szczyrk <Jakub Szczyrk>
* Fix repair cost - consider block size. Decision repair always when invalid files.

* Refactoring

* Refactoring

Co-authored-by: Jakub Szczyrk <Jakub Szczyrk>
* Restriction of hash repair for a large number of files

* Refactoring

* Refactoring

Co-authored-by: Jakub Szczyrk <Jakub Szczyrk>
* Remove check version for diff

* VersionIntegrity was used instead of ICheckVersionIntegrityCommand

Co-authored-by: Jakub Szczyrk <Jakub Szczyrk>
* Unpacking only added and modified files. For unchanged files only entry change at app_data.json. Refactoring LocalMetaData

* Refactoring

* Refactoring

Co-authored-by: Jakub Szczyrk <Jakub Szczyrk>
…s to install files during diff. Added caching of broken files during diff and a subsequent attempt to repair these files.

## [3.17.10.0]
### Added
- Caching for diff and content app summary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caching is only a way to achieve an improvement - changelog should describe the effect. For instance, this one should be listed under Changed category as Improve speed of getting API data by caching it.

### Added
- Caching for diff and content app summary
- Restriction of hash repair for a large number of files
- Reduced number of events sent for version integration check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be listed under Changed category.

- Processing of contnet summary files during diff

### Fixed
- The retry button resumes the update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Retrying the failed operation from error dialog.

- Check version for diff
- Processing of contnet summary files during diff

### Fixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple Fixed changelog category.

## [3.17.10.0]
### Added
- Caching for diff and content app summary
- Restriction of hash repair for a large number of files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be under Changed category as Disable checking hashes for repairing after failed installation if files count is over 10000.

- Caching of broken files during diff and a subsequent attempt to repair these files.

### Changed
- Repair cost and decision
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be listed under Fixed category as Wrong cost calculation of repairing while making installation decision.

Comment on lines +18 to +19
### Fixed
- The retry button resumes the update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate entry.

- The retry button resumes the update

### Removed
- Check version for diff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be under Changed category as Optimize diff installation time by reusing version integrity check results.

The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [3.17.10.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog for Changed - Optimize diff installation by leveraging information about unchanged files.

Comment on lines -15 to +16
public const int DefaultTryCount = 10;
public const int DefaultDelayMsec = 500;
public const int DefaultTryCount = 5;
public const int DefaultDelayMsec = 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't RetryStrategy used somewhere else where this change might break previous behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants