Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add e2e test to on-pr workflow #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Jan 22, 2025

What's New?

runs

  • successful run where version has not changed
  • successful run where go.mod major version was bumped and the version passes through the input correctly

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 force-pushed the PSG-5780-sdk-test-go branch from e5381d3 to 93010f3 Compare January 22, 2025 17:40
"target_sdk":"go",
"use_test_release":true,
"sdk_branch_ref":"${{ github.head_ref || github.ref_name }}",
"test_release_version":"${{ steps.get_sdk_version.outputs.version }}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be an empty string '' if version is not set (no change), which will translate to an empty input for the upstream workflow so that it will grab the version from the release please branch manifest instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant