-
Notifications
You must be signed in to change notification settings - Fork 70
Move noise sampling to pulser-core #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
For this changes to be relevant, it was convened the final object should contain:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a preliminary consideration on this, I'd love to discuss it further when we get the chance
from pulser.sequence import Sequence | ||
|
||
|
||
class BaseHamiltonian: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a glance, it sounds more natural to me that this would be called HamiltonianData
and given to Hamiltonian
, rather than its base class. Of course, the design of the class itself would have to be adapted to this paradigm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to agree here. It's not a big change to make.
Currently, each emulator has to implement its custom noise sampling. They are generally inspired from pulser-simulation. If we want to support a new noise type, we have to implement it in each emulator. This proposes to move the tools to generate samples with noise to pulser-core.