Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x/mod dependency for the new golang version format #32

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

Arlet2
Copy link

@Arlet2 Arlet2 commented Oct 30, 2023

Update dependency for parsing go.mod file. Now it can parse go.mod with the new golang version format 1.23.3 instead of the old format 1.21

@Arlet2 Arlet2 changed the title Update x/mod for the new golang version format Update x/mod dependency for the new golang version format Oct 30, 2023
@qequ
Copy link
Collaborator

qequ commented Oct 31, 2023

Hi, @Arlet2 thanks for the PR, can you check the pipeline that breaks? it seems to be related to x

@parvez3019
Copy link
Owner

Hi @Arlet2 also can you please remove vendor package from the PR, and put that in .gitignore

@Arlet2
Copy link
Author

Arlet2 commented Nov 1, 2023

Hi, @parvez3019! I pushed your suggestions to PR

Copy link
Owner

@parvez3019 parvez3019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@qequ
Copy link
Collaborator

qequ commented Nov 1, 2023

LGTM

@qequ qequ merged commit 48a4975 into parvez3019:main Nov 2, 2023
2 checks passed
@Arlet2 Arlet2 deleted the update-version-format branch January 13, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants