Add task list based profiling #1337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly chosen chunk size, and to be sparse aware
Co-authored-by: Luke Roberts <[email protected]>
Yurlungur
reviewed
Nov 13, 2025
Collaborator
Yurlungur
left a comment
Yurlungur
left a comment
There was a problem hiding this comment.
Looks like some of the new tests you added are failing. Otherwise LGTM.
Comment on lines
+98
to
+99
| PARTHENON_REQUIRE(dict_.count(label) > 0, "Asking for non-existent timing region."); | ||
| return dict_[label]; |
Collaborator
There was a problem hiding this comment.
Why not just do this?
Suggested change
| PARTHENON_REQUIRE(dict_.count(label) > 0, "Asking for non-existent timing region."); | |
| return dict_[label]; | |
| return dict_.at(label); |
Collaborator
Author
There was a problem hiding this comment.
I like having the descriptive error message and I think this isn't performance critical.
pdmullen
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds the capability to time groupings of tasks in a task list for profiling. For instance, it was used to create the the by multigrid level timing plot shown below. For an example of using the task list timing, see the unit test.
Additionally, this PR starts on adding some unit tests for the tasking infrastructure itself.
mg_timing.pdf
PR Checklist