Multi-Channel Audio playback #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive for Windows (WASAPI) at the moment.
…mat for both multi-channel audio and PS5 haptics audio.
…Ds as a signal for choosing the default audio device.
…pecification of the audio format the device should initialize for playback.
…oid too. However, actual surround sound audio won't be rendered on those platforms.
how did this compile before, i wonder
fix android build
dvijayak
added
2. Review requested
Kodikuu
requested changes
Sep 10, 2024
There was a problem hiding this comment.
I understand on Windows and macOS are the current targets, but I've made not of what's missing and provided documentation links for Android and Linux to receive support for this too. Android may be easy, though Linux looks a little more involved.
The only required change is the issue with the description
Kodikuu
added
1. Coding
dvijayak
added
2. Review requested
Kodikuu
approved these changes
Sep 13, 2024
Namaneo
added
3. 2nd review stage
dvijayak
added
2. Review requested
dvijayak
added
3. 2nd review stage
RonaldH-Parsec
requested changes
Nov 21, 2024
dvijayak
added
1. Coding
Kodikuu
approved these changes
Dec 13, 2024
dvijayak
added
3. 2nd review stage
…IDs and configuration enums in matoya.
src/windows/audio.c
Outdated
|
|
||
| } else { | ||
| pwfx.Format.wFormatTag = WAVE_FORMAT_EXTENSIBLE; | ||
| pwfx.Format.cbSize = 22; |
There was a problem hiding this comment.
I know the documentation states "should be bigger than 22", I think this should be set to:
Suggested change
| pwfx.Format.cbSize = 22; | |
| pwfx.Format.cbSize = sizeof(WAVEFORMATEXTENSIBLE); |
There was a problem hiding this comment.
Actually, 22 is correct but it is misleading. The more accurate way to write it is:
pwfx.Format.cbSize = sizeof(WAVEFORMATEXTENSIBLE) - sizeof(WAVEFORMATEX);Why? Because docs say that the value is the total bytes of data appended to the WAVEFORMATEX struct. Not the total bytes of the whole struct.
I have made this change now, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multi-channel audio support to MTY_Audio for Windows and macOS. The
MTY_AudioCreatefunction has been enhanced with the ability to specify multi-channel audio parameters. All platforms have been changed to respect these parameters however proper surround sound audio will only work on Windows and macOS at the moment.