Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: do thin LTO and singular codegen-unit on release #970

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

perf: do thin LTO and singular codegen-unit on release #970

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67052e8
perf: thin LTO on release
Oct 22, 2024
37df961
thin is default
de-sh Oct 23, 2024
3b2a43a
Merge branch 'main' into perf
de-sh Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@ resolver = "2"
# - https://github.com/apache/arrow-rs/pull/6260
# But a new version hasn't been published to crates.io for this yet. So, we are using this patch temporarily.
object_store = { git = "https://github.com/apache/arrow-rs.git", rev = "23b6ff9f432e8e29c08d47a315ba0b7cb8758225" }

[profile.release]
lto = "thin"
de-sh marked this conversation as resolved.
Show resolved Hide resolved
codegen-units = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is worth trying with FAT as well and see if we get any perf advantages. cc @nikhilsinhaparseable

Loading