Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename P_NODE_URL to P_INGESTOR_URL #748

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

nitisht
Copy link
Member

@nitisht nitisht commented Apr 8, 2024

P_INGESTOR_URL is a better name for this env variable.

@Eshanatnight
Copy link
Contributor

changes required in server.rs it still calling CONFIG.parseable.node_url
Line Numbers 231 and 483.

Apart from that LGTM

Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have fixed the code where it was still looking for node_url, good to merge now

@nitisht nitisht merged commit 91cce24 into parseablehq:main Apr 9, 2024
6 checks passed
@nitisht nitisht deleted the rename-env branch April 9, 2024 02:48
nikhilsinhaparseable added a commit to nikhilsinhaparseable/parseable that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants