Align OpenTelemetry crates for opentelemetry_sdk 0.32.1#1717
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR updates OpenTelemetry-related dependency versions in ChangesTelemetry dependency upgrade
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Cargo.toml (1)
121-129: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRemove the unused
rt-tokiofeature —opentelemetry_sdkonly feedsBatchSpanProcessorhere, so keeprt-tokioonly if another workspace path needs Tokio runtime integration.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Cargo.toml` around lines 121 - 129, The opentelemetry_sdk dependency is enabling the unused rt-tokio feature even though this crate only uses BatchSpanProcessor here; remove the rt-tokio feature from the opentelemetry_sdk entry unless another symbol in the workspace explicitly needs Tokio runtime integration. Keep the dependency versions unchanged and update the Cargo.toml dependency declaration accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Cargo.toml`:
- Around line 121-129: The opentelemetry_sdk dependency is enabling the unused
rt-tokio feature even though this crate only uses BatchSpanProcessor here;
remove the rt-tokio feature from the opentelemetry_sdk entry unless another
symbol in the workspace explicitly needs Tokio runtime integration. Keep the
dependency versions unchanged and update the Cargo.toml dependency declaration
accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 763c617e-6b1d-4724-ae45-b4a78c586cd6
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml
Bumps [opentelemetry_sdk](https://github.com/open-telemetry/opentelemetry-rust) from 0.31.0 to 0.32.1. - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/main/docs/release_0.32.md) - [Commits](open-telemetry/opentelemetry-rust@v0.31.0...opentelemetry-semantic-conventions-0.32.1) --- updated-dependencies: - dependency-name: opentelemetry_sdk dependency-version: 0.32.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Fixes #XXXX.
Description
This PR updates the OpenTelemetry dependency stack to a compatible 0.32.x/0.33.x set, resolving the build failure caused by
mixed
opentelemetryversions in the dependency graph.The original bump to
opentelemetry_sdk 0.32.1introduced trait mismatches betweenopentelemetry_sdk,opentelemetry-otlp,opentelemetry-stdout,opentelemetry-proto, andtracing-opentelemetry. To fix this, the telemetry dependencies were alignedto matching versions so the tracing/export pipeline compiles cleanly again.
Key changes
opentelemetryto0.32.0opentelemetry_sdkto0.32.1opentelemetry-otlpto0.32.0opentelemetry-stdoutto0.32.0opentelemetry-prototo0.32.0tracing-opentelemetryto0.33.0Cargo.lockto reflect the resolved dependency graphSummary by CodeRabbit