update rust version to 1.88 in Dockerfiles #1386
Conversation
WalkthroughThe Rust base image version in the build stage was updated from 1.84.0-bookworm to 1.88.0-bookworm in both Dockerfile.dev and Dockerfile.kafka. No other modifications were made to the build steps, dependencies, or configuration. Changes
Estimated code review effort1 (~2 minutes) Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Dockerfile.dev (1)
17-17: Pin image by digest (and optionally include patch version) for reproducible buildsBumping to
rust:1.88.0-bookwormis fine, but the tag alone is mutable.
For deterministic CI / supply-chain security you usually want either:
- The fully qualified patch tag (e.g.
1.88.1-bookwormonce available), and/or- The immutable digest:
-FROM rust:1.88.0-bookworm AS builder +FROM rust:1.88.0-bookworm@sha256:<digest> AS builderPlease verify the digest and update the tag across all Dockerfiles to avoid “works-on-my-machine” drift.
Dockerfile.kafka (1)
17-17: Keep Kafka image aligned with dev image – pin by digest as wellSame concern as in Dockerfile.dev: the mutable
rust:1.88.0-bookwormtag can unexpectedly move.
Recommend pinning to the same digest used inDockerfile.devto guarantee both images use an identical toolchain.-FROM rust:1.88.0-bookworm AS builder +FROM rust:1.88.0-bookworm@sha256:<digest> AS builderDouble-check that the digest you choose actually contains the required Debian 12 (bookworm) layer.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Dockerfile.dev(1 hunks)Dockerfile.kafka(1 hunks)
🧠 Learnings (2)
📓 Common learnings
Learnt from: nikhilsinhaparseable
PR: parseablehq/parseable#1302
File: .github/workflows/build.yaml:170-175
Timestamp: 2025-04-26T03:58:02.341Z
Learning: In the parseable project, the Linux-specific environment variables (PKG_CONFIG_PATH, SASL2_DIR, OPENSSL_DIR, OPENSSL_ROOT_DIR, SASL2_STATIC) in the Kafka build step of GitHub Actions workflows don't cause issues for macOS builds and can safely be applied to both platforms.
Dockerfile.kafka (1)
Learnt from: nikhilsinhaparseable
PR: #1302
File: .github/workflows/build.yaml:170-175
Timestamp: 2025-04-26T03:58:02.341Z
Learning: In the parseable project, the Linux-specific environment variables (PKG_CONFIG_PATH, SASL2_DIR, OPENSSL_DIR, OPENSSL_ROOT_DIR, SASL2_STATIC) in the Kafka build step of GitHub Actions workflows don't cause issues for macOS builds and can safely be applied to both platforms.
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: nikhilsinhaparseable
PR: parseablehq/parseable#1302
File: .github/workflows/build.yaml:170-175
Timestamp: 2025-04-26T03:58:02.341Z
Learning: In the parseable project, the Linux-specific environment variables (PKG_CONFIG_PATH, SASL2_DIR, OPENSSL_DIR, OPENSSL_ROOT_DIR, SASL2_STATIC) in the Kafka build step of GitHub Actions workflows don't cause issues for macOS builds and can safely be applied to both platforms.
Dockerfile.kafka (1)
Learnt from: nikhilsinhaparseable
PR: #1302
File: .github/workflows/build.yaml:170-175
Timestamp: 2025-04-26T03:58:02.341Z
Learning: In the parseable project, the Linux-specific environment variables (PKG_CONFIG_PATH, SASL2_DIR, OPENSSL_DIR, OPENSSL_ROOT_DIR, SASL2_STATIC) in the Kafka build step of GitHub Actions workflows don't cause issues for macOS builds and can safely be applied to both platforms.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: Build Default x86_64-apple-darwin
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: coverage
Summary by CodeRabbit