Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor and expose ingest server util #1091

Merged
merged 3 commits into from
Jan 10, 2025
Merged

refactor and expose ingest server util #1091

merged 3 commits into from
Jan 10, 2025

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 9, 2025

Fixes #XXXX.

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 9, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12707982359

Details

  • 0 of 68 (0.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 12.364%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/staging.rs 0 2 0.0%
src/handlers/http/modal/ingest_server.rs 0 66 0.0%
Files with Coverage Reduction New Missed Lines %
src/handlers/http/modal/ingest_server.rs 5 0.0%
Totals Coverage Status
Change from base Build 12682370366: -0.02%
Covered Lines: 2408
Relevant Lines: 19476
💛 - Coveralls

nikhilsinhaparseable
nikhilsinhaparseable previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

nikhilsinhaparseable
nikhilsinhaparseable previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit cc259d5 into parseablehq:main Jan 10, 2025
6 checks passed
@de-sh de-sh deleted the expose branch January 10, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@de-sh @coveralls @nikhilsinhaparseable @nitisht