Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for kafka on mac #1090

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fixes for kafka on mac #1090

merged 1 commit into from
Jan 10, 2025

Conversation

AdheipSingh
Copy link
Contributor

@AdheipSingh AdheipSingh commented Jan 9, 2025 •
edited
Loading

Fixes #XXXX.

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12685793544

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 12.387%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/cli.rs 0 4 0.0%
Totals Coverage Status
Change from base Build 12682370366: -0.001%
Covered Lines: 2415
Relevant Lines: 19497
💛 - Coveralls

@nitisht nitisht requested a review from de-sh January 10, 2025 06:05
@nitisht nitisht merged commit 7c2bb3e into parseablehq:main Jan 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-sh de-sh de-sh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdheipSingh @coveralls @de-sh @nitisht