Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use clap::Parser for readability #1088

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 8, 2025

Fixes #XXXX.

Description

This has been in the works for long, finally figured out how to simplify the flow and get rid of the "junk" code involving unnecessary arg matching(totally my opinion), but this I believe is a readability win for the CLI and should allow us to work on further modularizing the codebase. It still needs a bit of testing to ensure parity with previous implementation.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 8, 2025

Pull Request Test Coverage Report for Build 12726302760

Details

  • 1 of 202 (0.5%) changed or added relevant lines in 37 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.3%) to 12.674%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/about.rs 0 1 0.0%
src/handlers/http/llm.rs 0 1 0.0%
src/handlers/http/mod.rs 0 1 0.0%
src/handlers/http/modal/ingest_server.rs 0 1 0.0%
src/handlers/http/modal/utils/logstream_utils.rs 0 1 0.0%
src/handlers/http/oidc.rs 0 1 0.0%
src/handlers/http/query.rs 0 1 0.0%
src/query/mod.rs 0 1 0.0%
src/utils/arrow/flight.rs 0 1 0.0%
src/alerts/mod.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/handlers/http/modal/mod.rs 1 26.6%
src/audit.rs 1 0.0%
src/cli.rs 6 0.0%
Totals Coverage Status
Change from base Build 12712271554: 0.3%
Covered Lines: 2408
Relevant Lines: 19000

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants