-
-
Notifications
You must be signed in to change notification settings - Fork 595
perf: Optimize bundle packaging with Vite #2553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2553 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6238 6238
Branches 1465 1466 +1
=========================================
Hits 6238 6238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Manuel <[email protected]> Signed-off-by: Diamond Lewis <[email protected]>
@dplewis Does this have an benefit for the developer, or is that merely an internal change? |
The question was to write a meaningful change log entry for developers. If you are curious to follow the trail of the issue, then you'll see that it has been opened as a solution to another issue. That other issue is just a refactor, but since this was now a larger change I'm asking whether there is anything relevant for developers to know about it that should go into the change log. |
@dplewis thanks for picking this up! What needs to be done before merging? Full e2e test? |
Dom't we already have a e2e test with puppeteer? |
@mtrezza In the future it should allow for tree shaking, I'm not sure if allows for it now as we will have to write tests for it. I can try to write one for it after this is merged.
@dblythy You wrote it lol Parse-SDK-JS/integration/test/ParseDistTest.js Lines 6 to 7 in 86eadbd
|
This is ready for review. |
FYI if #2501 is merged the build size will be reduced ~16%. Before
After
|
Let's merge this as |
Browserify
with Vite
for bundling
@mtrezza Good idea! I change the title |
I see you've made a commit after your last comment, is this now good to merge? |
It is good to merge |
# [6.2.0-alpha.3](6.2.0-alpha.2...6.2.0-alpha.3) (2025-04-15) ### Performance Improvements * Optimize bundle packaging with Vite ([#2553](#2553)) ([a4b19e5](a4b19e5))
🎉 This change has been released in version 6.2.0-alpha.3 |
Pull Request
Issue
Vite is more modern than browserify and has better node polyfilling than standalone rollup.
Closes: #2410
Closes: #2425
Approach
Limitations
Bundle size and build speed has increased. There are PR's opened to remove dependencies which should significantly reduce the size.
Before:
After:
Shoutout to @dblythy for getting started on this!