-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Reorganize type definition test files #2488
base: alpha
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2488 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6268 6268
Branches 1468 1452 -16
=========================================
Hits 6268 6268 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@mtrezza I added one example for Parse.Session since it's a small implementation. The community can addon more files in the future. An added benefit is we can ensure that all definitions are accounted for once the tests are migrated. In this case Parse.Session has all types tested. You can check by comparing it to the definition file ParseSession.d.ts |
@@ -53,6 +53,7 @@ | |||
"@semantic-release/npm": "12.0.1", | |||
"@semantic-release/release-notes-generator": "14.0.3", | |||
"@types/facebook-js-sdk": "3.3.11", | |||
"@types/jest": "29.5.14", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this needed for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s how I’m able to use it
and describe
in the definition test files. It’s also useful if we ever convert the unit tests to Typescript
Pull Request
Issue
All definition tests are contained in single file. This is hard to maintain and isn't scalable.
Ref: #2012
Approach
Tasks