Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Typescript instructions to Contributing guide #2463

Open
wants to merge 11 commits into
base: alpha
Choose a base branch
from

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Feb 20, 2025

Pull Request

Issue

Typescript instructions are missing.

Ref: #2012

Approach

  • Properly document how to build and test type definitions

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

parse-github-assistant bot commented Feb 20, 2025

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e6dc1b5) to head (dc8d025).

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2463   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6259      6259           
  Branches      1466      1450   -16     
=========================================
  Hits          6259      6259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dplewis dplewis requested a review from a team February 20, 2025 19:39
@dplewis
Copy link
Member Author

dplewis commented Feb 24, 2025

@mtrezza How does this look? Feel free to change the verbiage

@mtrezza
Copy link
Member

mtrezza commented Mar 3, 2025

Does this require any changes, now that #2462 has been merged?

@dplewis
Copy link
Member Author

dplewis commented Mar 3, 2025

@mtrezza No changes needed.

@dplewis dplewis requested a review from mtrezza March 5, 2025 16:40
@mtrezza
Copy link
Member

mtrezza commented Mar 5, 2025

I believe I have seen some potential for improvement but didn't get around typing it up yet. On my list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants