-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Remove dtslint #2435
ci: Remove dtslint #2435
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2435 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6256 6256
Branches 1452 1478 +26
=========================================
Hits 6256 6256 ☔ View full report in Codecov by Sentry. |
@@ -102,7 +101,6 @@ | |||
"test": "cross-env PARSE_BUILD=node jest", | |||
"test:mongodb": "npm run test:mongodb:runnerstart && npm run integration", | |||
"test:mongodb:runnerstart": "mongodb-runner start -- --port 27017", | |||
"test:types": "dtslint --expectOnly types", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I figured out how to enable full typescript support with shipping types to npm. I was waiting for #2425 to be merged so we don’t have conflicts
@dblythy the reason why dtslint is here is because we haven’t moved away from definitelyTyped yet. Once we move away then this can be removed |
@dplewis I've added the link in the issue description for why we're removing this. The package doesn't seem to be intended to be used that way and we ran into issues in Parse Server. If you follow the thread you'll find people hacking stuff together to make this work somehow. Even though it seems to work in this repo for now, we're removing it preemptively to rely solely on the types build step not to fail for the CI job to pass. |
@mtrezza go for it |
Do you have any concerns? |
@dblythy @mtrezza I'd recommend keeping this until someone can get the type test suite to pass. There is a Here is the test suite for reference copied from DT Edit: It should be easy to replace |
PR on hold; see #2452 (comment) |
🎉 This change has been released in version 6.0.0 |
Pull Request
Issue
Remove types check; reason see parse-community/parse-server#9581.
Approach
Tasks