ci: Remove dtslint

[dblythy]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

Remove types check; reason see parse-community/parse-server#9581.

Approach

Tasks

• Add tests
• Add changes to documentation (guides, repository pages, code comments)

[parse-github-assistant]

I will reformat the title to use the proper commit message syntax.

[parse-github-assistant]

Thanks for opening this pull request!

• ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fa34827) to head (8f51a54).
Report is 18 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff            @@
##             alpha     #2435   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6256      6256           
  Branches      1452      1478   +26     
=========================================
  Hits          6256      6256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dplewis]

I think I figured out how to enable full typescript support with shipping types to npm. I was waiting for #2425 to be merged so we don’t have conflicts

[dplewis]

@dblythy the reason why dtslint is here is because we haven’t moved away from definitelyTyped yet. Once we move away then this can be removed

[mtrezza]

@dplewis I've added the link in the issue description for why we're removing this. The package doesn't seem to be intended to be used that way and we ran into issues in Parse Server. If you follow the thread you'll find people hacking stuff together to make this work somehow. Even though it seems to work in this repo for now, we're removing it preemptively to rely solely on the types build step not to fail for the CI job to pass.

[dplewis]

@mtrezza go for it

[mtrezza]

Do you have any concerns?

[dplewis]

@dblythy @mtrezza I'd recommend keeping this until someone can get the type test suite to pass. There is a Cannot find namespace 'Parse' error when using at the top level that is stopping a typescript release.

Here is the test suite for reference copied from DT
https://github.com/parse-community/Parse-SDK-JS/blob/alpha/types/tests.ts

Edit: It should be easy to replace dtslintwith eslint-plugin-expect-type

[dplewis]

@dblythy I created a PR #2452 to show case my last comment. I agree dtslint should be removed in the future.

[mtrezza]

PR on hold; see #2452 (comment)

[parseplatformorg]

🎉 This change has been released in version 6.0.0