Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to support requests to Ads API. #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add method to support requests to Ads API. #38

wants to merge 1 commit into from

Conversation

jamesvl
Copy link

@jamesvl jamesvl commented Jan 25, 2016

At this time, supports bare requests going to the new URL.

I don't anticipate that there will be a need to add methods to emulate all of the Ads API functionality - using this request method directly should be enough. (And since their ads API is still at version "0", it's subject to changes anyway.)

p.s. still learning how Elixir testing works - I'm not familiar with the VCR fixtures in use. Possible test to add would be like this:

  test "sends ads request method to list ad accounts" do
    response = ExTwitter.ads_request(:get, "0/accounts")
    accts = ExTwitter.JSON.get(response, :data)
    assert Enum.count(accts) == ExTwitter.JSON.get(response, :total_count)
  end

At this time, supports bare requests going to the new URL.
@parroty
Copy link
Owner

parroty commented Jan 27, 2016

Thanks for the PR. I'm wondering how the external API signature should be (as defined in https://github.com/parroty/extwitter/blob/master/lib/extwitter.ex).

I'm looking the site https://dev.twitter.com/ads/overview, but haven't been able to find the good reference (API list for the endpoint). Do you have any insights?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants