This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add setter configurable only for benchmarking or tests #9668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a setter for BlockNumberProvider if compiling with runtime-benchmarks features. This allows to write benchmarking that is independent to the BlockProvider used, as it allows to set the desired mocked block number.
This is a problem we have encountered in moonbeam-foundation/crowdloan-rewards#44 (cc @JoshOrndorff), where we want to write benchmark code that is agnostic of the block provider. But to benchmark correctly one of the extrinsics, we need to specifically set the block number in the block provider.