FinalityNotification: Directly include stale blocks #9904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The finality notification was already carrying the information about the stale heads. However, most users of the stale heads were expanding these stale heads to all the stale blocks. So, we were iterating the same forks multiple times in the node for each finality notification. Also in a possible future where we start actually pruning headers as well, expanding these forks would fail. So, this pull request is changing the finality notification to directly carry the stale blocks (which were calculated any way already).
|
/cmd prdoc --audience node_dev --bump major |
…e_dev --bump major'
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
…ication-stale-blocks' into bkchr-finality-notfication-stale-blocks
acatangiu
approved these changes
Oct 1, 2025
| finalized: vec![header.hash()], | ||
| stale_blocks: stale_blocks | ||
| .into_iter() | ||
| .map(|h| StaleBlock { hash: h, is_head: false }) |
There was a problem hiding this comment.
is_head: false set for all stale_blocks here. not familiar with this trigger_finality_stream function, can it be called with any "head" among stale_blocks?
There was a problem hiding this comment.
This is test code and the implementation right now doesn't care if this is a head or not.
skunert
approved these changes
Oct 7, 2025
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
The finality notification was already carrying the information about the stale heads. However, most users of the stale heads were expanding these stale heads to all the stale blocks. So, we were iterating the same forks multiple times in the node for each finality notification. Also in a possible future where we start actually pruning headers as well, expanding these forks would fail. So, this pull request is changing the finality notification to directly carry the stale blocks (which were calculated any way already). --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The finality notification was already carrying the information about the stale heads. However, most users of the stale heads were expanding these stale heads to all the stale blocks. So, we were iterating the same forks multiple times in the node for each finality notification. Also in a possible future where we start actually pruning headers as well, expanding these forks would fail.
So, this pull request is changing the finality notification to directly carry the stale blocks (which were calculated any way already).