Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump VALIDATION_CODE_BOMB_LIMIT #7710

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+14 −2
Open

Bump VALIDATION_CODE_BOMB_LIMIT #7710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85b6365
Bump VALIDATION_CODE_BOMB_LIMIT
sandreim Feb 25, 2025
2537e67
remove max code size
sandreim Feb 25, 2025
096b33a
Update from sandreim running command 'prdoc --bump minor --audience n…
github-actions[bot] Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions polkadot/node/primitives/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ use polkadot_primitives::{
vstaging::CommittedCandidateReceiptV2 as CommittedCandidateReceipt, BlakeTwo256, BlockNumber,
CandidateCommitments, CandidateHash, ChunkIndex, CollatorPair, CompactStatement, CoreIndex,
EncodeAs, Hash, HashT, HeadData, Id as ParaId, PersistedValidationData, SessionIndex, Signed,
UncheckedSigned, ValidationCode, ValidationCodeHash, MAX_CODE_SIZE, MAX_POV_SIZE,
UncheckedSigned, ValidationCode, ValidationCodeHash, MAX_POV_SIZE,
};
pub use sp_consensus_babe::{
AllowedSlots as BabeAllowedSlots, BabeEpochConfiguration, Epoch as BabeEpoch,
Expand Down Expand Up @@ -69,7 +69,7 @@ const MERKLE_NODE_MAX_SIZE: usize = 512 + 100;
const MERKLE_PROOF_MAX_DEPTH: usize = 8;

/// The bomb limit for decompressing code blobs.
pub const VALIDATION_CODE_BOMB_LIMIT: usize = (MAX_CODE_SIZE * 4u32) as usize;
pub const VALIDATION_CODE_BOMB_LIMIT: usize = 32 * 1024 * 1024;

/// The bomb limit for decompressing PoV blobs.
pub const POV_BOMB_LIMIT: usize = (MAX_POV_SIZE * 4u32) as usize;
Expand Down
12 changes: 12 additions & 0 deletions prdoc/pr_7710.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
title: Bump VALIDATION_CODE_BOMB_LIMIT
doc:
- audience: Node Dev
description: |-
It used to be 16MiB some [time ago](https://github.com/paritytech/polkadot-sdk/commit/6b1baba49072aa99763b53b4ed1c2347e9b74339#diff-f0f67ea8902415829518ebc28ae8f60bdb286ebce3c4d141d31392983fa98ef7L52). Bumping to 32MiB sounds sensible to me, as we've seen some recent runtimes expanding close to the previous 16MiB.

This is just a short term fix for https://github.com/paritytech/polkadot-sdk/issues/7664 - needs to be backported and deployed ASAP.

While this unblocks assethub, I will create another PR to promote it into a HostConfiguration parameter and associated runtime api.
crates:
- name: polkadot-node-primitives
bump: minor
Loading